Skip to content
This repository was archived by the owner on Jul 8, 2025. It is now read-only.

Comments

feat: Implement IPickupEvent to ExplodingGrenadeEventArgs and ChangedIntoGrenadeEventArgs#9

Open
louis1706 wants to merge 145 commits intoExSLMod-Team:devfrom
warquys:AddIPickupEvent
Open

feat: Implement IPickupEvent to ExplodingGrenadeEventArgs and ChangedIntoGrenadeEventArgs#9
louis1706 wants to merge 145 commits intoExSLMod-Team:devfrom
warquys:AddIPickupEvent

Conversation

@louis1706
Copy link

Implement IPickupEvent to ExplodingGrenadeEventArgs and ChangedIntoGrenadeEventArgs.

Description

Describe the changes
Explicit Interface Implementation of IPickupEvent to ExplodingGrenadeEventArgs and ChangedIntoGrenadeEventArgs.

What is the current behavior? (You can also link to an open issue here)
ExplodingGrenadeEventArgs and ChangedIntoGrenadeEventArgs are not an IPickupEvent..

What is the new behavior? (if this is a feature change)
ExplodingGrenadeEventArgs and ChangedIntoGrenadeEventArgs are now an IPickupEvent..

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.

Other information:
Sugestion of banalnybanan: https://discord.com/channels/656673194693885975/663978314683252777/1337846404013490216


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

I do not have an SCP sl server, can some one test it for me :)

@github-actions github-actions bot added the Events This doesn't seem right label May 18, 2025
BoltonDev and others added 27 commits May 18, 2025 22:23
* LabAPI Update (ExMod-Team#435)

* No error for build

* Fix Exiled

* Fix RoundEnding

* Now is fucking separated by default

* CustomSubtitles

* Missing IsCustomAnnouncement

* Fix 3 patch & removal of CustomHealthStat

* Fix UsingAndCancellingItemUse

* Fix TogglingFlashlight

* La Flemme ?

* La flemme 2

* Fix ReservedSlotPatch

* Fix PickingUpItem(PickingUpAmmo)

* Fix Hurt event

* Fix FlippingCoin & EscapingPocketDimension

* Fix FailingEscapePocketDimension

* EscapingAndEscaped fix patch

* Fix UpgradingPlayer patch

* Fix BeingObserved

* Fix PlacingTantrum

* Fix FinishingRecall

* ChangingCamera (Not working)

* putting again the event than i was lazzy to fix

* Rework InteractingDoor Patch

missing removing the Prefix part lol
& SkillIssueFix

* Remove useless using and warning disable

* OUPS

* if stupidity was me it's here (i am stupid)

* Fixing Noclip with breakingchange

* CustomHumeShieldStat

* Fix InteractingGenerator

* Fix ChangingCamera

* Not finish

* InteractingDoor swap CanInteract & IsAllowed back to normal

* Player::Gravity

* Gravity in wrong place

* IHumeShieldRole for Human

* Fix BlastDoors & add OpenBlastDoor

* Fix SpawningRagdoll Scale & missing argument when modify

* Now fix in LabAPI only

* we will keep the funny Ragdoll scale

* Fix Merge & Split Command

* new workflow for LabAPI

* LabAPI Update 14.0.3 (ExMod-Team#439)

* No error for build

* Fix Exiled

* Fix RoundEnding

* Now is fucking separated by default

* CustomSubtitles

* Missing IsCustomAnnouncement

* Fix 3 patch & removal of CustomHealthStat

* Fix UsingAndCancellingItemUse

* Fix TogglingFlashlight

* La Flemme ?

* La flemme 2

* Fix ReservedSlotPatch

* Fix PickingUpItem(PickingUpAmmo)

* Fix Hurt event

* Fix FlippingCoin & EscapingPocketDimension

* Fix FailingEscapePocketDimension

* EscapingAndEscaped fix patch

* Fix UpgradingPlayer patch

* Fix BeingObserved

* Fix PlacingTantrum

* Fix FinishingRecall

* ChangingCamera (Not working)

* putting again the event than i was lazzy to fix

* Rework InteractingDoor Patch

missing removing the Prefix part lol
& SkillIssueFix

* Remove useless using and warning disable

* OUPS

* if stupidity was me it's here (i am stupid)

* Fixing Noclip with breakingchange

* CustomHumeShieldStat

* Fix InteractingGenerator

* Fix ChangingCamera

* Not finish

* InteractingDoor swap CanInteract & IsAllowed back to normal

* Player::Gravity

* Gravity in wrong place

* IHumeShieldRole for Human

* Fix BlastDoors & add OpenBlastDoor

* Fix SpawningRagdoll Scale & missing argument when modify

* Now fix in LabAPI only

* we will keep the funny Ragdoll scale

* Fix Merge & Split Command

* new workflow for LabAPI

* NW_Documentation

* SCP:SL LabAPI 14.0.3

* Fix One IL Error Patch (2 remain from previous update)

* use Specific build for LabAPI

* Miss updating this file

* 9.6.0-beta3

* this will need to be revert

* push_nuget not working for LabAPI

* Fixing RoundEnd Patch

* Adding CustomRole::Gravity

* Remove Testing Log

* fix: Command events fix (ExMod-Team#444)

command fixes

* fix: Fixing UnlockingGenerator

* Fix RoundEnd completelly

* fix: Hurting event NRE fix (ExMod-Team#443)

fix: one day i'll kill person who made this

Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>

* 9.6.0-beta4

* this will required to be revert

* fix: InteractingDoorEvent::CanInteract (ExMod-Team#463)

* Fix InteractingDoorEvent::CanInteract

* Oupsy

* Fixed Error & InteractingScp330 IL Code

* TODO: Fix THE CRASH ISSUE

* Fix Consumed Event - doubt

* Fix & Small change on UsingAndCancellingItemUse

* Fix an issue where HashSetPool was never return

* Fix IL CODE error & remove debug

* Add warning in case of missing PrefabType

* Capybara Toy

* remove using

* Fix SpawningRagdoll not setting NetworkInfo

* Fix Ragdoll Scale & ConsumingEvent

* Missing NetworkInfo.Scale Argument

* Fix: Door.Get(GameObject)

* TantrumHazard is always null

* 9.6.0-beta5

* Update EXILED_DLL_ARCHIVER_URL for LabAPI

* fix: use basegame validation for CustomInfo (ExMod-Team#452)

* Validate using basegame

* Update EXILED/Exiled.API/Features/Player.cs

---------

Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>

* feat: Custom limits for armor & virtual dmg for customweapon (ExMod-Team#477)

* fix: activating warhead panel event fix (ExMod-Team#504)

fix: fix for activating warhead panel

* Fix Error (from Conflict)

* Fix doc error

* Fix few error

* refactor!: update to 14.1 (ExMod-Team#508)

* refactor!: update to 14.1

* fix: few patches fix

* feat: new custom keycard logic

* fix: ActivatingWarheadPanel event

* fix: checkpoint sequence time

* fix: Shot event

* fix: DroppingCandy event

* Fix last Error on Release Build

* Update new PrefabType

* fix: AnnouncingScpTermination event

* fix: SpawningItem event error (require testing)

* fix: Shot.cs fix

* analysis error

* Fix error

* Fix build error

* NW_Documentation

* fix: announcing wave entrance

* Reference new Room

* Fix Build error

* fix: fixes pickingup event

* Nameless Skill Issue

* fix: locker patch

* fix: spawning room connector

* CameraToy

* Get CameraToy

* Finish InteractableToy & fix doc

* fix Error for build

* Remove todo

* fix: generator events

* ElevatorType.ServerRoom

* Fix a 2 hours loss

* Fix NW moment

* fix: interacting generator

* fix: interacting locker event

* fix: missing obstacle shot

* fix: KeycardInteracting again

* Fix SendingCassieMessage

* fix: temp fix interacting door (need to refactor)

* refactor: change the property

* fix doc

* extension for Scp127 & ServerRoom

* FirearmType.Scp127

* AdminToyList

* fix: camera weren't added

* new CameraType

* wrong doc

* fix: interacting door event (improved)

* Invalid Camera

* Better doc

* fix: interacting door (bolton issue)

* FixDamagingWindow index

* RemoveBreakingChange

* Fix FailingEscapePocketDimensionEventArgs

---------

Co-authored-by: Bolton <48883340+BoltonDev@users.noreply.github.com>
Co-authored-by: VALERA771 <val.germanov@gmail.com>
Co-authored-by: VALERA771 <72030575+VALERA771@users.noreply.github.com>

* 9.6.0-beta6

* SNOWBALL DO NOT EXIST

* fix: ChangingCamera event (ExMod-Team#511)

* fix: useless fix now & prevent crash (ExMod-Team#512)

* fix: EndingRound event IsAllowed (ExMod-Team#513)

fix: EndingRound event isallowed

* bump: 9.6.0-beta7

* fix: few fixes (ExMod-Team#514)

* fix: keycard interacting

* fix: EscapingEvent IsAllowed

* fix: command type invalid

* fix: landing event

* fix: EscapingPocketDimension event

* fix: Handcuffing / RemovingHandcuff events

* fix: sentvalidcommand event

* bump: 9.6.0-beta8

* fix: fix AutoUpdater Directory finder (ExMod-Team#515)

* Update Capybara.cs

* Revert "Update Capybara.cs"

This reverts commit 6ea4789.

* fix autoupdater

* ok now its fixed 100%

* fix: custom weapons not doing default damage when set to below 0 (ExMod-Team#518)

* fix custom weapons not doing default damage when set to below 0

* make default damage -1

* Workflow fix (ExMod-Team#3)

* v9.5.2

* Update release.yml

* Update main.yml

* update nuget

* update docs

* update dev

* Fixing Error & Removing Property that will not be implmented

* EffectType.Scp1344Detected

* Update labapi.yml

* Update labapi.yml

* TextToy Implementation API

* chore: remove hub (doesn't exist anymore)

* fix: update exmod -> exslmod & bump: 9.6.0

* fix: missing some change

* missing hub

---------

Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>
Co-authored-by: Yamato <louismonneyron5@yahoo.com>
Co-authored-by: VALERA771 <72030575+VALERA771@users.noreply.github.com>
Co-authored-by: Nameless <85962933+Misfiy@users.noreply.github.com>
Co-authored-by: SlejmUr <slejmur@protonmail.com>
Co-authored-by: VALERA771 <val.germanov@gmail.com>
Co-authored-by: Mike <146554836+MikeSus1@users.noreply.github.com>
Co-authored-by: TtroubleTT <121741230+TtroubleTT@users.noreply.github.com>
* Update SpawningItem.cs

* spacing
fix player.MessageTranslated kick players
* fix KeybindSetting and RoundEnd transpiler

I think it all works, I ran server and no errors, I got on and ended round and no errors

* Fix Scale (ScaleController is mid) Fix ChangingLeverStatus event

I think these work
Fix dropping/dropped item event
## Description
**Describe the changes** 


**What is the current behavior?** (You can also link to an open issue
here)


**What is the new behavior?** (if this is a feature change)


**Does this PR introduce a breaking change?** (What changes might users
need to make in their application due to this PR?)


**Other information**:

<br />

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentations
<br />

## Submission checklist
<!--- Put an `x` in all the boxes that apply: -->
- [ ] I have checked the project can be compiled
- [ ] I have tested my changes and it worked as expected

### Patches (if there are any changes related to Harmony patches)
- [ ] I have checked no IL patching errors in the console

### Other
- [ ] Still requires more testing
## Description
**Describe the changes** 


**What is the current behavior?** (You can also link to an open issue
here)


**What is the new behavior?** (if this is a feature change)


**Does this PR introduce a breaking change?** (What changes might users
need to make in their application due to this PR?)


**Other information**:

<br />

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentations
<br />

## Submission checklist
<!--- Put an `x` in all the boxes that apply: -->
- [ ] I have checked the project can be compiled
- [ ] I have tested my changes and it worked as expected

### Patches (if there are any changes related to Harmony patches)
- [ ] I have checked no IL patching errors in the console

### Other
- [ ] Still requires more testing
## Description
**Describe the changes** 


**What is the current behavior?** (You can also link to an open issue
here)


**What is the new behavior?** (if this is a feature change)


**Does this PR introduce a breaking change?** (What changes might users
need to make in their application due to this PR?)


**Other information**:

<br />

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentations
<br />

## Submission checklist
<!--- Put an `x` in all the boxes that apply: -->
- [ ] I have checked the project can be compiled
- [ ] I have tested my changes and it worked as expected

### Patches (if there are any changes related to Harmony patches)
- [ ] I have checked no IL patching errors in the console

### Other
- [ ] Still requires more testing
…m#560)

* Added Safety Checks

* Added SpawningRagdoll event for Safety Checks

* Added Safety Checks

* Simplfy

* Simplfy
…d-Team#573)

fix: Update spawning logic to use IsFpcRole for role vdation
* for 14.1.1 hint update

* Resolve recursive call (sry my mistake)
## Description
**Describe the changes** 


**What is the current behavior?** (You can also link to an open issue
here)


**What is the new behavior?** (if this is a feature change)


**Does this PR introduce a breaking change?** (What changes might users
need to make in their application due to this PR?)


**Other information**:

<br />

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Documentations
<br />

## Submission checklist
<!--- Put an `x` in all the boxes that apply: -->
- [ ] I have checked the project can be compiled
- [ ] I have tested my changes and it worked as expected

### Patches (if there are any changes related to Harmony patches)
- [ ] I have checked no IL patching errors in the console

### Other
- [ ] Still requires more testing
Banalny-Banan and others added 30 commits August 9, 2025 15:39
…am#616)

add Player.Enumerable and Player.Count properties
* Fixes the Frenchie's English

* New Custom Stuff (Untested)

* Corrected Attachment Changing

* Minor fix

---------

Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>
* Create RoundTargetCount.cs

* Modify TargetMethod() to My way :3

* fix variable Name

---------

Co-authored-by: Yamato <louismonneyron5@yahoo.com>
Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>
* tkt pas

* oopsie

* i'm dumb

* fix

* oups

* oups

---------

Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>
* clean.cs

* Update ChangedAspectRatio.cs

* Update ChangedAspectRatio.cs

* Update ChangedAspectRatio.cs

* Update ChangedAspectRatio.cs

* Update ChangedAspectRatio.cs

* Update ChangedAspectRatio.cs

* Update ChangedAspectRatio.cs

---------

Co-authored-by: Yamato <louismonneyron5@yahoo.com>
* Create SavingByAntiScp207EventArgs.cs

* Update Player.cs

* Create SavingByAntiScp207.cs

---------

Co-authored-by: Yamato <louismonneyron5@yahoo.com>
* Update MirrorExtensions.cs

* Update MirrorExtensions.cs

* IndexOf is better

---------

Co-authored-by: Yamato <louismonneyron5@yahoo.com>
* Update Player.cs

* Update Firearm.cs

* validation for nre

* Add validation for nre

* Update Firearm.cs

* Update Firearm.cs
Replaces explicit type with target-typed 'new' when creating a new RagdollData instance in the CreationTime setter for improved code readability.
I WAS THE CAUSE OF THE FALL DAMAGE BUG NOOOOOOOOOOOO

I JUST DIDNT SEE A SINGLE brfalse_s 😭 😭 😭 😭 😭 😭 😭 😭 😭 😭
* no more breaching changes

* checking

* Update Player.cs

Co-authored-by: Nameless <85962933+Misfiy@users.noreply.github.com>

* Update Player.cs

Co-authored-by: Nameless <85962933+Misfiy@users.noreply.github.com>

* Update LeadingTeam.cs

* Update Player.cs

---------

Co-authored-by: Nameless <85962933+Misfiy@users.noreply.github.com>
* Create FixCapturePosition.cs

* Update FixCapturePosition.cs

* Update EXILED/Exiled.Events/Patches/Fixes/FixCapturePosition.cs

* Update FixCapturePosition.cs

---------

Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>
PlaceBlood

Co-authored-by: VALERA771 <72030575+VALERA771@users.noreply.github.com>
fix: Attacker being null if GenericDamageHandler is used
…Team#633)

* Update CustomWeapon.cs

* Update ReloadingWeapon.cs

* Update ReloadingWeapon.cs

* Update Player.cs

* Update Events.cs

* Update Player.cs

* Update ReloadingWeaponEventArgs.cs

* Update UnloadingWeaponEventArgs.cs

* Update Player.cs

* Delete EXILED/Exiled.Events/Patches/Events/Player/ReloadingWeapon.cs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Events This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.